Skip to content

MultipartType_PortDesc and PortStatus #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

MultipartType_PortDesc and PortStatus #4

wants to merge 4 commits into from

Conversation

@lpzgithub
Copy link

@lpzgithub lpzgithub commented Mar 14, 2018

  1. Add MultipartType_PortDesc Parse
  2. modify PortStatus UnmarshalBinary Parse field is incorrect

@lpzgithub
1. Add MultipartType_PortDesc
9e4720f 
2. modify PortStatus UnmarshalBinary Parse field is incorrect
@lpzgithub
modiy the Segment error if MultipartRequest is no body
948d8e2
g1rana
g1rana reviewed Mar 16, 2018
View reviewed changes
openflow13/multipart.go

n = 0

for _, r := range s.ports {
Copy link

@g1rana g1rana Mar 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove these extra spaces here ?

Copy link
Author

@lpzgithub lpzgithub Mar 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok，I I adjust the code again

jojimt
jojimt requested changes May 12, 2021
View reviewed changes
openflow13/multipart.go
p := new(PortStatus)
p.Header = NewOfp13Header()
p.pad = make([]byte, 7)
p.Desc = *NewPhyPort()
Copy link
Contributor

@jojimt jojimt May 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please nil check.

GraysonWu pushed a commit to GraysonWu/libOpenflow that referenced this pull request Jul 8, 2021
@antoninbas
Create releases automatically when VERSION is updated (contiv#4)
dbd1b5d 
Signed-off-by: Antonin Bas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jojimt jojimt jojimt requested changes

+1 more reviewer

@g1rana g1rana g1rana left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lpzgithub @jojimt @g1rana