fix: loading of blocks with inputs. in CLI flags #8259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
|
✅ Review Complete Code Review Summary |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 issues found across 19 files
Prompt for AI agents (all 3 issues)
Understand the root cause of the following 3 issues and fix them.
<file name="packages/config-yaml/src/markdown/agentFiles.ts">
<violation number="1" location="packages/config-yaml/src/markdown/agentFiles.ts:160">
Whitespace-only rules survive because trimming happens after the Boolean filter. Reverse the order or trim inside the filter to prevent empty strings from being returned.</violation>
</file>
<file name="packages/config-yaml/src/load/unroll.ts">
<violation number="1" location="packages/config-yaml/src/load/unroll.ts:249">
replaceInputsWithSecrets never rewrites the injected ${ {inputs.*} } variables, so injected blocks continue referencing inputs.* and the CLI secret rendering fix does not take effect.</violation>
</file>
<file name="extensions/cli/src/hubLoader.ts">
<violation number="1" location="extensions/cli/src/hubLoader.ts:305">
isStringRule now returns true for Windows file paths (e.g., `C:\\rules.md`), so those rules are treated as inline strings and never loaded from disk. Add the missing `"\\"` check to keep Windows paths classified as files.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
sestinj
requested changes
Oct 15, 2025
use agent option for cn remote
sestinj
approved these changes
Oct 16, 2025
|
🎉 This PR is included in version 1.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
inputs.can now use fully-feature rendered secretsRearranges config loading to use the existing flow for injecting blocks for flags like --mcp and --agent model/tools etc., so that they can have secrets rendered. Replaces
inputs.withsecrets.for injected blocks, since they cannot use inputs.As a side effect, also adds file path/URI support for various flags etc.
Summary by cubic
Fixes secret rendering for blocks injected via CLI flags (--mcp, --agent model/tools) by moving injection into the main config loading flow and auto-replacing inputs.* with secrets.* for injected blocks. Removes the old enhancer and aligns services with the unified loader.
Bug Fixes
Refactors