Skip to content

Conversation

@Patrick-Erichsen
Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen commented Oct 14, 2025

Summary by cubic

Fixed incorrect tool call error logging in the GUI by passing structured error reasons from core to the UI.

  • Bug Fixes
    • Added errorReason to the tools/call protocol and captured ContinueError.reason in callTool.
    • Updated GUI thunk to build ContinueError with the provided reason, defaulting to Unspecified when absent.

@Patrick-Erichsen Patrick-Erichsen marked this pull request as ready for review October 14, 2025 21:40
@Patrick-Erichsen Patrick-Erichsen requested a review from a team as a code owner October 14, 2025 21:40
@Patrick-Erichsen Patrick-Erichsen requested review from sestinj and removed request for a team October 14, 2025 21:40
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 14, 2025
@github-actions
Copy link

github-actions bot commented Oct 14, 2025

✅ Review Complete

Code Review Summary

⚠️ Continue configuration error. Please verify that the assistant exists in Continue Hub.


Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 14, 2025
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to use type continue error reason not string

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Oct 14, 2025
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant comment not request change.

@RomneyDa RomneyDa dismissed their stale review October 14, 2025 22:34

meant to comment

RomneyDa
RomneyDa previously approved these changes Oct 14, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 14, 2025
@RomneyDa RomneyDa merged commit 698ad37 into main Oct 14, 2025
53 of 54 checks passed
@RomneyDa RomneyDa deleted the pe/tool-call-errors branch October 14, 2025 23:41
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 14, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2025
@sestinj
Copy link
Contributor

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.28.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants