Fix: Remove <think> blocks from chat title generation #8239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update removeCodeBlocksAndTrim to handle <think> blocks from models like qwen3 - Add comprehensive test coverage for think block removal - Fixes issue where chat titles showed thinking process instead of content Fixes continuedev#5689
dosubot
bot
added
the
size:M
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
tingwai
approved these changes
Oct 15, 2025
Collaborator
tingwai
left a comment
tingwai
left a comment
There was a problem hiding this comment.
Looks good, thanks for the improvement!
Contributor
|
🎉 This PR is included in version 1.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed autodetect title generation for models that use
<think>blocks (like qwen3:30b). Updated theremoveCodeBlocksAndTrimfunction to remove thinking content before generating chat titles, preventing titles from showing the model's reasoning process instead of actual response content.AI Code Review
@continue-reviewChecklist
Tests
Added comprehensive test coverage in
core/util/index.test.tsfor:<think>block removal from textFixes
Closes #5689
Updated the
removeCodeBlocksAndTrimfunction to use greedy regex matching (/<think>[\s\S]*<\/think>/g) to properly handle all think block scenarios while maintaining existing code block removal functionality.Summary by cubic
Fixed autodetected chat titles for models that emit blocks (e.g., qwen3) by stripping thinking and code blocks before building the title, so titles reflect the actual answer.