Skip to content

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Oct 14, 2025

Description

Rename workflows to agent files in CLI code
Breaking changes in config yaml for parsing function/type naming
Also breaking change of flag from --workflow to --agent


Summary by cubic

Renamed “workflows” to “agent files” across the CLI and config-yaml. This includes new CLI flags, service/types, and YAML parser names, and is a breaking change for consumers.

  • Refactors

    • Replaced WorkflowService with AgentFileService and SERVICE_NAMES.AGENT_FILE.
    • Switched hub package type/processor from “workflow” to “agent-file” and parseAgentFile.
    • Updated ConfigEnhancer, ModelService, ToolPermissionService, and chat flow to use agent file state (prompt, tools, model).
    • config-yaml exports now come from agentFiles.ts (AgentFile, parseAgentFile, parseAgentFileTools, serializeAgentFile).
  • Migration

    • CLI: use --agent instead of --workflow.
    • Imports: replace WorkflowFile → AgentFile, parseWorkflowFile/parseWorkflowTools → parseAgentFile/parseAgentFileTools, and import from agentFiles.ts.
    • Hub: use package type “agent-file” for slugs and processors.
    • Services: switch SERVICE_NAMES.WORKFLOW → SERVICE_NAMES.AGENT_FILE and workflow* state fields → agentFile* equivalents (including agentFilePolicyCount).

@RomneyDa RomneyDa requested a review from a team as a code owner October 14, 2025 01:45
@RomneyDa RomneyDa requested review from tingwai and removed request for a team October 14, 2025 01:45
@github-actions
Copy link

github-actions bot commented Oct 14, 2025

✅ Review Complete

Code Review Summary

⚠️ Continue configuration error. Please verify that the assistant exists in Continue Hub.


@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Oct 14, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 26 files

Prompt for AI agents (all 3 issues)

Understand the root cause of the following 3 issues and fix them.


<file name="extensions/cli/src/shared-options.ts">

<violation number="1" location="extensions/cli/src/shared-options.ts:114">
The inheritable option key should stay aligned with the &quot;--agent&quot; flag; using &quot;agent-file&quot; prevents subcommands from inheriting the agent slug.</violation>
</file>

<file name="packages/config-yaml/src/markdown/agentFiles.test.ts">

<violation number="1" location="packages/config-yaml/src/markdown/agentFiles.test.ts:73">
The expected error message now asserts &quot;Agent File file...&quot; but parseAgentFile still throws &quot;Agent file must contain YAML frontmatter with a &#39;name&#39; field&quot;. Please update the expectation to match the real error string so the test reflects the implementation.</violation>
</file>

<file name="extensions/cli/src/services/AgentFileService.test.ts">

<violation number="1" location="extensions/cli/src/services/AgentFileService.test.ts:227">
This suite is asserting against the mocked agentFileProcessor defined earlier in the test file, so it never covers the real implementation—regressions in hubLoader.ts would still pass. Consider unmocking or importing the actual agentFileProcessor before running these expectations.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Oct 14, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 14, 2025
@sestinj
Copy link
Contributor

sestinj commented Oct 14, 2025

I see nothing wrong

@RomneyDa RomneyDa merged commit 3c630d7 into main Oct 14, 2025
80 of 85 checks passed
@RomneyDa RomneyDa deleted the dallin/workflow-to-agent branch October 14, 2025 03:57
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 14, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2025
@github-actions github-actions bot added the tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product label Oct 14, 2025
@sestinj
Copy link
Contributor

sestinj commented Oct 14, 2025

🎉 This PR is included in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:XXL This PR changes 1000+ lines, ignoring generated files. tier 1 Big feature that took multiple weeks to launch and represents a big milestone for the product

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants