-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat: rename workflows to agent files #8224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Review Complete Code Review Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 issues found across 26 files
Prompt for AI agents (all 3 issues)
Understand the root cause of the following 3 issues and fix them.
<file name="extensions/cli/src/shared-options.ts">
<violation number="1" location="extensions/cli/src/shared-options.ts:114">
The inheritable option key should stay aligned with the "--agent" flag; using "agent-file" prevents subcommands from inheriting the agent slug.</violation>
</file>
<file name="packages/config-yaml/src/markdown/agentFiles.test.ts">
<violation number="1" location="packages/config-yaml/src/markdown/agentFiles.test.ts:73">
The expected error message now asserts "Agent File file..." but parseAgentFile still throws "Agent file must contain YAML frontmatter with a 'name' field". Please update the expectation to match the real error string so the test reflects the implementation.</violation>
</file>
<file name="extensions/cli/src/services/AgentFileService.test.ts">
<violation number="1" location="extensions/cli/src/services/AgentFileService.test.ts:227">
This suite is asserting against the mocked agentFileProcessor defined earlier in the test file, so it never covers the real implementation—regressions in hubLoader.ts would still pass. Consider unmocking or importing the actual agentFileProcessor before running these expectations.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
|
I see nothing wrong |
|
🎉 This PR is included in version 1.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Rename workflows to agent files in CLI code
Breaking changes in config yaml for parsing function/type naming
Also breaking change of flag from --workflow to --agent
Summary by cubic
Renamed “workflows” to “agent files” across the CLI and config-yaml. This includes new CLI flags, service/types, and YAML parser names, and is a breaking change for consumers.
Refactors
Migration