Skip to content

fix: treat premature close during tool calls as a tool error #8221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 14, 2025
Merged

fix: treat premature close during tool calls as a tool error #8221

merged 9 commits into from
Oct 14, 2025

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Oct 13, 2025 •
edited
Loading

Description

Catches premature close error during streaming if there are tool calls, and marks them as errored with instructions to break up tool call into small chunks. This is because the common premature close case is during create/edit operations and only happens in large outputs/files

image image

@RomneyDa RomneyDa requested a review from a team as a code owner October 13, 2025 17:38
@RomneyDa RomneyDa requested review from sestinj and removed request for a team October 13, 2025 17:38
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 13, 2025
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

⚠️ PR Title Format

Your PR title doesn't follow the conventional commit format, but this won't block your PR from being merged. We recommend using this format for better project organization.

Expected Format:

<type>[optional scope]: <description>

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

✅ Review Complete

Code Review Summary

⚠️ Continue configuration error. Please verify that the assistant exists in Continue Hub.

@RomneyDa RomneyDa marked this pull request as draft October 13, 2025 17:48
cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

@RomneyDa RomneyDa changed the title Dallin/con 4298 premature tool call fix: treat premature close during tool calls as a tool error Oct 13, 2025
@RomneyDa RomneyDa marked this pull request as ready for review October 13, 2025 22:30
@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

✅ Review Complete

Code Review Summary

⚠️ Continue configuration error. Please verify that the assistant exists in Continue Hub.

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

sestinj
sestinj requested changes Oct 14, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Oct 14, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 14, 2025
@sestinj sestinj merged commit ee269fa into main Oct 14, 2025
53 of 55 checks passed
@sestinj sestinj deleted the dallin/con-4298-premature-tool-call branch October 14, 2025 06:14
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 14, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2025
@sestinj
Copy link
Contributor

sestinj commented Oct 14, 2025

🎉 This PR is included in version 1.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@sestinj sestinj sestinj approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Issues and PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RomneyDa @sestinj