Skip to content

fix: HOTFIX stop agent loop if aborted/not streaming #8208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2025
Merged

fix: HOTFIX stop agent loop if aborted/not streaming #8208

merged 2 commits into from
Oct 13, 2025

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Oct 12, 2025 •
edited by cubic-dev-ai bot
Loading

Description

Currently after depth 2+ in agent loop you can't cancel it

Summary by cubic

Fixes agent loop cancellation so it stops immediately when the stream is aborted or not streaming. Prevents the loop from continuing past depth 2+.

  • Bug Fixes
    • Added early returns in streamNormalInput at preprocess, policy evaluation, and auto-stream dispatch when abort is signaled or session.isStreaming is false.
    • Blocks further tool call generation and auto approvals after cancel.

@RomneyDa RomneyDa requested a review from a team as a code owner October 12, 2025 06:17
@RomneyDa RomneyDa requested review from tingwai and removed request for a team October 12, 2025 06:17
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 12, 2025
@github-actions
Copy link

github-actions bot commented Oct 12, 2025 •
edited
Loading

✅ Review Complete

Code Review Summary

⚠️ Continue configuration error. Please verify that the assistant exists in Continue Hub.

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Oct 12, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Oct 13, 2025
@tingwai tingwai merged commit 93a2dff into main Oct 13, 2025
68 of 70 checks passed
@tingwai tingwai deleted the dallin/cant-cancel-streaming branch October 13, 2025 22:35
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 13, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2025
@sestinj
Copy link
Contributor

sestinj commented Oct 14, 2025

🎉 This PR is included in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@tingwai tingwai tingwai approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer released size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Issues and PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RomneyDa @sestinj @tingwai