Skip to content

Conversation

@sestinj
Copy link
Contributor

@sestinj sestinj commented Oct 9, 2025

Description

[ What changed? Feel free to be brief. ]

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Add expect to the runloop blueprint setup to enable scripted interactions with interactive CLI prompts (works with asciinema). This prevents failures in workflows that need to respond to TTY prompts during tests or recordings.

@sestinj sestinj requested a review from a team as a code owner October 9, 2025 05:18
@sestinj sestinj requested review from Patrick-Erichsen and removed request for a team October 9, 2025 05:18
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 9, 2025
@sestinj sestinj merged commit 65aa21f into main Oct 9, 2025
34 of 35 checks passed
@sestinj sestinj deleted the sestinj-patch-1 branch October 9, 2025 05:18
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Oct 9, 2025
@github-actions
Copy link

github-actions bot commented Oct 9, 2025

⚠️ PR Title Format

Your PR title doesn't follow the conventional commit format, but this won't block your PR from being merged. We recommend using this format for better project organization.

Expected Format:

<type>[optional scope]: <description>

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name=".github/workflows/runloop-blueprint-template.json">

<violation number="1" location=".github/workflows/runloop-blueprint-template.json:8">
Add -y to this apt install so the setup remains non-interactive; otherwise the command will prompt for confirmation and block automated runs.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

"sudo apt install -y ripgrep",
"sudo apt install asciinema"
"sudo apt install asciinema",
"sudo apt install expect"
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add -y to this apt install so the setup remains non-interactive; otherwise the command will prompt for confirmation and block automated runs.

Prompt for AI agents
Address the following comment on .github/workflows/runloop-blueprint-template.json at line 8:

<comment>Add -y to this apt install so the setup remains non-interactive; otherwise the command will prompt for confirmation and block automated runs.</comment>

<file context>
@@ -4,6 +4,7 @@
     &quot;sudo apt install -y ripgrep&quot;,
-    &quot;sudo apt install asciinema&quot;
+    &quot;sudo apt install asciinema&quot;,
+    &quot;sudo apt install expect&quot;
   ]
 }
</file context>
Suggested change
"sudo apt install expect"
"sudo apt install -y expect"
Fix with Cubic

@sestinj
Copy link
Contributor Author

sestinj commented Oct 12, 2025

🎉 This PR is included in version 1.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor Author

sestinj commented Oct 14, 2025

🎉 This PR is included in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor Author

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

released size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants