fix: flakey CLI tests #8124
fix: flakey CLI tests #8124
Conversation
dosubot
bot
added
the
size:XS
|
✅ Review Complete Code Review Summary |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
tingwai
force-pushed
the
tingwai/flakey-test
branch
2 times, most recently
from
bb754f7 to
e0f382b
Compare
tingwai
force-pushed
the
tingwai/flakey-test
branch
from
e0f382b to
70554f5
Compare
dosubot
bot
added
size:M
|
✅ Review Complete Code Review Summary |
| expect(frame).toContain("Ask anything"); | ||
| // UI should still be functional and show the typed special characters | ||
| // Note: "Ask anything" placeholder is replaced when text is typed | ||
| expect(frame).toContain("!@#$%^&*()"); |
There was a problem hiding this comment.
Are you sure about this one? Unlike the other changes this one changes the expected behavior.
There was a problem hiding this comment.
Yes, up on line 56 we're doing stdin.write("!@#$%^&*()") so this assertion shouldn't be expecting 'Ask anything' which is the placeholder text of the user input box
|
🎉 This PR is included in version 1.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
[ What changed? Feel free to be brief. ]
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Fixes a flaky TUIChat file search test by simulating real typing. Adds 250ms delays between '@' inputs so TextBuffer doesn’t treat them as a single paste (200ms window), making the test reliable.