Skip to content

Conversation

@sestinj
Copy link
Contributor

@sestinj sestinj commented Oct 1, 2025

Description

Filters out backticks from the start and end of next edit completions, which was happening sometimes in markdown files.


Summary by cubic

Remove markdown code fences from next edit completions so we don’t insert stray ``` lines in markdown files. This makes generated edits cleaner and avoids malformed code blocks.

  • Bug Fixes
    • Strip a leading line starting with and a trailing line that is exactly in postprocessCompletion, without touching inline backticks.
    • Added unit tests covering language fences, whitespace, inline backticks, and empty/single-line cases.

@sestinj sestinj requested a review from a team as a code owner October 1, 2025 18:19
@sestinj sestinj requested review from RomneyDa and removed request for a team October 1, 2025 18:19
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 1, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@sestinj sestinj merged commit 89826f0 into main Oct 2, 2025
31 of 33 checks passed
@sestinj sestinj deleted the nate/next-edit-backticks branch October 2, 2025 05:52
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Oct 2, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2025
@sestinj
Copy link
Contributor Author

sestinj commented Oct 2, 2025

🎉 This PR is included in version 1.24.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor Author

sestinj commented Oct 5, 2025

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor Author

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

released size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants