Skip to content

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Sep 26, 2025

Description

last commit pushed to #7956 broke it


Summary by cubic

Fix JSON MCP config loading by aligning schemas with actual config shapes and updating the loader to always parse project and desktop mcpServers. Restores MCP discovery for Claude Code and Claude Desktop JSON configs.

  • Bug Fixes
    • Schemas: mcpServers is required in Desktop configs; projects is required in Code configs (project mcpServers remain optional).
    • Loader: removed conditional guards and now consistently collects mcpServers from projects and desktop configs after a successful parse.

@RomneyDa RomneyDa requested a review from a team as a code owner September 26, 2025 20:46
@RomneyDa RomneyDa requested review from Patrick-Erichsen and removed request for a team September 26, 2025 20:46
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 26, 2025
@github-actions
Copy link

github-actions bot commented Sep 26, 2025

✅ Review Complete

⚠️ AI review completed but no review output was generated.

Likely cause: Expired CONTINUE_API_KEY or missing continuedev/review-bot assistant

📋 View workflow logs for details.


@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 26, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 26, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@Patrick-Erichsen Patrick-Erichsen merged commit e734ad7 into main Sep 26, 2025
55 of 58 checks passed
@Patrick-Erichsen Patrick-Erichsen deleted the dallin/JSON-MCP-support branch September 26, 2025 21:12
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Sep 26, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2025
@sestinj
Copy link
Contributor

sestinj commented Sep 26, 2025

🎉 This PR is included in version 1.22.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 1, 2025

🎉 This PR is included in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 15, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants