feat: handle environment.json file in cn serve #7984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
3 issues found across 2 files
Prompt for AI agents (all 3 issues)
Understand the root cause of the following 3 issues and fix them.
<file name="extensions/cli/src/commands/serve.ts">
<violation number="1" location="extensions/cli/src/commands/serve.ts:61">
Blocks server startup via synchronous execSync; consider deferring until after the server starts or running asynchronously to avoid long startup delays.</violation>
<violation number="2" location="extensions/cli/src/commands/serve.ts:61">
Automatically executes an install command from .continue/environment.json on startup, enabling arbitrary command execution without user confirmation. Gate behind an explicit flag/confirmation or restrict allowed commands.</violation>
<violation number="3" location="extensions/cli/src/commands/serve.ts:63">
Rule violated: **Don't use console.log**
Replace console.error with logger.error per logging guideline.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
extensions/cli/src/commands/serve.ts
Outdated
|
|
||
| // Run environment install script if available | ||
| try { | ||
| await runEnvironmentInstall(); |
Contributor
There was a problem hiding this comment.
Blocks server startup via synchronous execSync; consider deferring until after the server starts or running asynchronously to avoid long startup delays.
Prompt for AI agents
Address the following comment on extensions/cli/src/commands/serve.ts at line 61:
<comment>Blocks server startup via synchronous execSync; consider deferring until after the server starts or running asynchronously to avoid long startup delays.</comment>
<file context>
@@ -55,6 +56,16 @@ export async function serve(prompt?: string, options: ServeOptions = {}) {
+ // Run environment install script if available
+ try {
+ await runEnvironmentInstall();
+ } catch (error) {
+ console.error(
</file context>
✅ Addressed in 012585a
extensions/cli/src/commands/serve.ts
Outdated
|
|
||
| // Run environment install script if available | ||
| try { | ||
| await runEnvironmentInstall(); |
Contributor
There was a problem hiding this comment.
Automatically executes an install command from .continue/environment.json on startup, enabling arbitrary command execution without user confirmation. Gate behind an explicit flag/confirmation or restrict allowed commands.
Prompt for AI agents
Address the following comment on extensions/cli/src/commands/serve.ts at line 61:
<comment>Automatically executes an install command from .continue/environment.json on startup, enabling arbitrary command execution without user confirmation. Gate behind an explicit flag/confirmation or restrict allowed commands.</comment>
<file context>
@@ -55,6 +56,16 @@ export async function serve(prompt?: string, options: ServeOptions = {}) {
+ // Run environment install script if available
+ try {
+ await runEnvironmentInstall();
+ } catch (error) {
+ console.error(
</file context>
extensions/cli/src/commands/serve.ts
Outdated
| try { | ||
| await runEnvironmentInstall(); | ||
| } catch (error) { | ||
| console.error( |
Contributor
There was a problem hiding this comment.
Rule violated: Don't use console.log
Replace console.error with logger.error per logging guideline.
Prompt for AI agents
Address the following comment on extensions/cli/src/commands/serve.ts at line 63:
<comment>Replace console.error with logger.error per logging guideline.</comment>
<file context>
@@ -55,6 +56,16 @@ export async function serve(prompt?: string, options: ServeOptions = {}) {
+ try {
+ await runEnvironmentInstall();
+ } catch (error) {
+ console.error(
+ chalk.red("Failed to run environment install script:"),
+ formatError(error),
</file context>
✅ Addressed in 012585a
dosubot
bot
added
size:L
github-actions
bot
added
the
tier 2
Contributor
Author
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this was shortest path to set up the husky pre-commit hook in background
Summary by cubic
Adds support for .continue/environment.json in cn serve. If the file defines an install command, it runs before the server starts to auto-setup the local environment (e.g., Husky hooks).