Skip to content

fix: ls tool relative paths #7982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2025
Merged

fix: ls tool relative paths #7982

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87266f5
fix: ls tool relative paths
RomneyDa Sep 25, 2025
b16fd9a
fix: list files prompt tweak
RomneyDa Sep 25, 2025
3841322
fix: revert preventing .. since absolute skirts
RomneyDa Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions extensions/cli/src/tools/listFiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,28 +22,34 @@ export const listFilesTool: Tool = {
readonly: true,
isBuiltIn: true,
preprocess: async (args) => {
// Resolve relative paths
const normalizedPath = path.normalize(args.dirpath);
const dirPath = path.resolve(process.cwd(), normalizedPath);

if (!fs.existsSync(dirPath)) {
throw new Error(`Directory does not exist: ${dirPath}`);
}

if (!fs.statSync(dirPath).isDirectory()) {
throw new Error(`Error: Path is not a directory: ${dirPath}`);
}

return {
args,
args: {
dirpath: dirPath,
},
preview: [
{
type: "text",
content: args.dirpath
? `Will list files in: ${formatToolArgument(args.dirpath)}`
content: dirPath
? `Will list files in: ${formatToolArgument(dirPath)}`
: "Will list files in current directory",
},
],
};
},
run: async (args: { dirpath: string }): Promise<string> => {
try {
if (!fs.existsSync(args.dirpath)) {
return `Error: Directory does not exist: ${args.dirpath}`;
}

if (!fs.statSync(args.dirpath).isDirectory()) {
return `Error: Path is not a directory: ${args.dirpath}`;
}

const files = fs.readdirSync(args.dirpath);
const fileDetails = files.map((file) => {
const fullPath = path.join(args.dirpath, file);
Expand Down
Loading