Skip to content

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Sep 25, 2025

Actual author @lixiaoyang1992, see
#7599

Reopening here since stale with @lixiaoyang1992 as coauthor

Fixes some mermaid styling


Summary by cubic

Improves Mermaid diagram rendering by wrapping the diagram with a .mermaid container and setting foreignObject elements to full width. Prevents clipping and ensures consistent layout.

  • Bug Fixes
    • Add .mermaid class to the diagram container for proper style scoping.
    • Set foreignObject width to 100% to avoid truncation in SVG-based diagrams.

@RomneyDa RomneyDa requested a review from a team as a code owner September 25, 2025 00:48
@RomneyDa RomneyDa requested review from sestinj and removed request for a team September 25, 2025 00:48
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 25, 2025
@github-actions
Copy link

⚠️ AI review completed but no review output was generated. Check the action logs for details.


💡 To request a new review, comment @continue-general-review

@RomneyDa RomneyDa changed the title fix: update MermaidBlock styles for improved rendering and add foreig… fix: update MermaidBlock styles for improved rendering and add foreignObject Sep 25, 2025
@github-actions
Copy link

AI Code Review

AI review failed due to service initialization issues. Please check the Continue API key and configuration.

No specific line comments generated.


💡 To request a new detailed review, comment @continue-detailed-review

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 25, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit 4dfe1ff into main Sep 25, 2025
69 of 71 checks passed
@Patrick-Erichsen Patrick-Erichsen deleted the dallin/mermaid-foreign-object branch September 25, 2025 22:58
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Sep 25, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2025
@sestinj
Copy link
Contributor

sestinj commented Sep 26, 2025

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 1, 2025

🎉 This PR is included in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants