Skip to content

feat(cli): show dangerous command once per session #7919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 26, 2025
Merged

feat(cli): show dangerous command once per session #7919

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e5ab9c
feat(cli): show dangerous command once per session
uinstinct Sep 23, 2025
85834fa
Merge branch 'main' into cli-danger-command
uinstinct Sep 24, 2025
2874c3a
store in state
uinstinct Sep 24, 2025
d66d700
refactor and rename variable
uinstinct Sep 25, 2025
affc0cb
Merge branch 'main' of https://github.com/continuedev/continue into u…
RomneyDa Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion extensions/cli/src/ui/components/ToolPermissionSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ import { defaultBoxStyles } from "../styles.js";

import { ToolPreview } from "./ToolPreview.js";

// show dangerous commmand warning only once per CLI process
let hasShownDangerousCommandWarning = false;

interface PermissionOption {
id: string;
name: string;
Expand Down Expand Up @@ -61,6 +64,13 @@ export const ToolPermissionSelector: React.FC<ToolPermissionSelectorProps> = ({
}) => {
const permissionOptions = getPermissionOptions();
const [selectedIndex, setSelectedIndex] = useState(0);
const [hasShownDangerousCommandWarningOnce] = useState(() => {
const prev = hasShownDangerousCommandWarning;
hasShownDangerousCommandWarning = true;
return prev;
});
const showDynamicWarning =
hasDynamicEvaluation && !hasShownDangerousCommandWarningOnce;

useInput((input, key) => {
if (key.return) {
Expand Down Expand Up @@ -125,7 +135,7 @@ export const ToolPermissionSelector: React.FC<ToolPermissionSelectorProps> = ({

<Box marginTop={1} flexDirection="column">
<Text color="dim">Would you like to continue?</Text>
{hasDynamicEvaluation && (
{showDynamicWarning && (
<Box marginTop={1}>
<Text color="yellow" dimColor>
Note: Dangerous commands will be blocked regardless of your
Expand Down
Loading