Skip to content

Conversation

@exigow
Copy link
Contributor

@exigow exigow commented Sep 5, 2025

Solves:

com.intellij.diagnostic.PluginException: Migrate com.github.continuedev.continueintellijextension.proxy.ProxyPoolingActivity to ProjectActivity [Plugin: com.github.continuedev.continueintellijextension]
	at com.intellij.ide.startup.impl.StartupManagerImpl.runPostStartupActivities(StartupManagerImpl.kt:275)
	at com.intellij.ide.startup.impl.StartupManagerImpl.access$runPostStartupActivities(StartupManagerImpl.kt:68)
	at com.intellij.ide.startup.impl.StartupManagerImpl$runPostStartupActivities$3$2.invokeSuspend(StartupManagerImpl.kt:191)

I fixed this because since bumping the platform version we were getting an exception on startup about a required migration.

Note: the new activity is asynchronous, so we don't need to create our own coroutine scope for polling the settings.

I tested this feature manually (change in settings is properly recognized & binary restarts on apply).


Summary by cubic

Migrated proxy polling from StartupActivity to ProjectActivity to fix the startup exception after the platform bump. Behavior is unchanged: settings changes are detected and the core restarts.

  • Bug Fixes
    • Switched to ProjectActivity and moved polling into suspend execute; removed custom CoroutineScope.
    • Resolved the PluginException requiring migration on startup.
    • Polls every 2s; settings changes trigger a restart as before.

@exigow exigow requested a review from a team as a code owner September 5, 2025 15:58
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 5, 2025
@github-actions
Copy link

github-actions bot commented Sep 5, 2025

⚠️ AI review completed but no review output was generated. Check the action logs for details.


💡 To request a new review, comment @continue-general-review

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 5, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 5, 2025
@RomneyDa
Copy link
Collaborator

RomneyDa commented Sep 9, 2025

@exigow looks like some failure is causing the jetbrains tests to be skipped

@exigow exigow marked this pull request as draft September 10, 2025 11:44
@RomneyDa
Copy link
Collaborator

@exigow bump

@exigow exigow force-pushed the exigow/migrate-proxy-activity-to-project-activity branch from 4f7e57e to 6c3c640 Compare September 26, 2025 14:50
@exigow exigow marked this pull request as ready for review September 26, 2025 14:52
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 26, 2025
@github-actions
Copy link

⚠️ AI review completed but no review output was generated. Check the action logs for details.


💡 To request a new review, comment @continue-general-review

@github-actions
Copy link

AI Code Review

AI review failed due to service initialization issues. Please check the Continue API key and configuration.

No specific line comments generated.


💡 To request a new detailed review, comment @continue-detailed-review

I fixed this because since bumping the platform version we were getting an exception on startup about a required migration.

Solves:
com.intellij.diagnostic.PluginException: Migrate com.github.continuedev.continueintellijextension.proxy.ProxyPoolingActivity to ProjectActivity [Plugin: com.github.continuedev.continueintellijextension]
	at com.intellij.ide.startup.impl.StartupManagerImpl.runPostStartupActivities(StartupManagerImpl.kt:275)
	at com.intellij.ide.startup.impl.StartupManagerImpl.access$runPostStartupActivities(StartupManagerImpl.kt:68)
	at com.intellij.ide.startup.impl.StartupManagerImpl$runPostStartupActivities$3$2.invokeSuspend(StartupManagerImpl.kt:191)

Note: the new activity is asynchronous, so we don't need to create our own coroutine scope for polling the settings.

I tested this feature manually (change in settings is properly recognized & binary restarts on apply).
@RomneyDa RomneyDa merged commit f940da1 into main Sep 26, 2025
75 of 78 checks passed
@RomneyDa RomneyDa deleted the exigow/migrate-proxy-activity-to-project-activity branch September 26, 2025 18:33
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Sep 26, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2025
@sestinj
Copy link
Contributor

sestinj commented Sep 26, 2025

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Sep 26, 2025

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Oct 1, 2025

🎉 This PR is included in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants