-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix: migrate proxy pooling activity to project activity #7609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migrate proxy pooling activity to project activity #7609
Conversation
|
💡 To request a new review, comment |
|
@exigow looks like some failure is causing the jetbrains tests to be skipped |
|
@exigow bump |
4f7e57e to
6c3c640
Compare
|
💡 To request a new review, comment |
AI Code ReviewAI review failed due to service initialization issues. Please check the Continue API key and configuration. No specific line comments generated. 💡 To request a new detailed review, comment |
I fixed this because since bumping the platform version we were getting an exception on startup about a required migration. Solves: com.intellij.diagnostic.PluginException: Migrate com.github.continuedev.continueintellijextension.proxy.ProxyPoolingActivity to ProjectActivity [Plugin: com.github.continuedev.continueintellijextension] at com.intellij.ide.startup.impl.StartupManagerImpl.runPostStartupActivities(StartupManagerImpl.kt:275) at com.intellij.ide.startup.impl.StartupManagerImpl.access$runPostStartupActivities(StartupManagerImpl.kt:68) at com.intellij.ide.startup.impl.StartupManagerImpl$runPostStartupActivities$3$2.invokeSuspend(StartupManagerImpl.kt:191) Note: the new activity is asynchronous, so we don't need to create our own coroutine scope for polling the settings. I tested this feature manually (change in settings is properly recognized & binary restarts on apply).
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Solves:
I fixed this because since bumping the platform version we were getting an exception on startup about a required migration.
Note: the new activity is asynchronous, so we don't need to create our own coroutine scope for polling the settings.
I tested this feature manually (change in settings is properly recognized & binary restarts on apply).
Summary by cubic
Migrated proxy polling from StartupActivity to ProjectActivity to fix the startup exception after the platform bump. Behavior is unchanged: settings changes are detected and the core restarts.