-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat: ✨ CLI: Add aws credentials onboarding #7443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sestinj not sure if this is expected but I wanted to be able to test the CLI localy to validate changes. |
Is there part of this message that got cut off, or what exactly went wrong here? General feedback on the PR: we aim to keep the CLI very simple for users, so a third option becoming visible right off the bat is not directionally something I would merge. That said, I wouldn't be opposed to some kind of auto-magic detection if that is possible (e.g. show an option only if we see AWS credentials) |
|
@sestinj I can most definitely make it work that way. |
|
Awesome! I think this will be really nice. Is it possible to detect automatically whether the AWS credentials have access to Bedrock? One concern would be that some large portion of developers have AWS creds on their machine, but that many of them are not set up to work with Bedrock, so this would be a frustrating dead end |
|
@sestinj three options. 1) we could have it work like Claude Code where it looks for the existence of a exported environment variable, or 2) have it look for the existence of a profile called "bedrock" to mirror the other extensions and only offer it then. The chances most developers have this profile is pretty slim. 3) we could go for a combo and use the environment variable and have it point to the AWS profile of choice. This might be the most robust option as it offers detection and customization of the profile. |
|
is the environment variable claude code-specific? Biggest thing is to avoid false positives (profiles that cause the option to be shown, but that then do not have access to bedrock). Would definitely be ok to look for profiles that are called "bedrock", this seems like the safest spot to start |
|
@sestinj Claude code is using an environment variable like this: Configure for Bedrock with Claude Sonnetexport CLAUDE_CODE_USE_BEDROCK=1 |
|
ok! cool. then yes that very clearly avoids false positives. happy to go forward with that |
|
@chezsmithy curious to check in on this. Pretty excited about this one. If you're not sure whether you'll be able to get around to it though might make sense to close, at least temporarily |
a1d34a3 to
9693dcc
Compare
9693dcc to
1a9c299
Compare
|
@sestinj ready for review. The failing tests appear unrelated to my changes. |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
CLI: Add aws onboarding option.
AWS Bedrock onboarding is triggered when the environment variable
CONTINUE_USE_BEDROCK=1is detected.This will assume AWS credentials are available via all the standard options once it uses the bedrock provider.
AI Code Review
@continue-general-reviewor@continue-detailed-reviewChecklist
Screen recording or screenshot
Tests
Updated specs
Performed manual testing
Updated onboarding tests
Summary by cubic
Adds an AWS credentials path to CLI onboarding so users can start with Bedrock-backed Claude without pasting API keys. The flow can auto-create config.yaml using the standard AWS credential chain.