cgroup: remove tun/tap from the default allow list #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, access to /dev/net/tun was enabled by the default built-in ruleset in runc since its very inception. Obviously, a container should not have access to tun/tap device, unless it is explicitly specified in configuration. Now, removing this might create a compatibility issue, but I see no other choice. Signed-off-by: Kir Kolyshkin <[email protected]>
Collaborator
|
LGTM @kolyshkin @giuseppe I am just curious why was reported BZ only reproduceable on |
Member
|
We do not use systemd to configure the cgroup |
Member
|
@kolyshkin are you able to merge on this repository? If so, please feel free to merge when you wish |
Member
|
I am merging since the runc PR was already merged |
Collaborator
Author
Nope, it says Only those with write access to this repository can merge pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, access to /dev/net/tun was enabled by the default
built-in ruleset in runc since its very inception.
Obviously, a container should not have access to tun/tap device, unless
it is explicitly specified in configuration.
Now, removing this might create a compatibility issue, but I see no
other choice.
Similar PR for runc: opencontainers/runc#3468
(I guess it makes sense to wait until that one is merged).