Lock to OS thread when Pdeathsig is set #86
Conversation
Codecov ReportBase: 21.52% // Head: 20.27% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 21.52% 20.27% -1.26%
==========================================
Files 7 7
Lines 683 735 +52
==========================================
+ Hits 147 149 +2
- Misses 499 545 +46
- Partials 37 41 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This has been open for quite awhile. Is there anyone specific I can ping to review it? |
samuelkarp
left a comment
samuelkarp
left a comment
There was a problem hiding this comment.
Our apologies for the delay. Thanks for opening this; I've left a couple suggestions for changes.
aaronlehmann
force-pushed
the
lock-os-thread
branch
from
a9d1516 to
51f9c48
Compare
See golang/go#27505 for context. Pdeathsig isn't safe to set without locking to the current OS thread, because otherwise thread termination will send the signal, which isn't the desired behavior. I discovered this while troubleshooting a problem that turned out to be unrelated, but I think it's necessary for correctness. Signed-off-by: Aaron Lehmann <[email protected]>
aaronlehmann
force-pushed
the
lock-os-thread
branch
from
51f9c48 to
1caf1a7
Compare
samuelkarp
dismissed
estesp’s stale review
Changes since previous approval, sorry @estesp!
|
Not in a huge rush for this one, but would just like to get it merged so we can close the book on it. Is there anything else you need from me to push it forward? |
5 participants
See golang/go#27505 for context.
Pdeathsigisn't safe to set without locking to the current OS thread, because
otherwise thread termination will send the signal, which isn't the
desired behavior.
I discovered this while troubleshooting a problem that turned out to be
unrelated, but I think it's necessary for correctness.
cc @coryb