Skip to content

Conversation

@ningmingxiao
Copy link
Contributor

Signed-off-by: ningmingxiao [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Base: 21.45% // Head: 20.69% // Decreases project coverage by -0.77% ⚠️

Coverage data is based on head (0c71c7f) compared to base (1c99ade).
Patch coverage: 37.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   21.45%   20.69%   -0.77%     
==========================================
  Files           7        7              
  Lines         685      715      +30     
==========================================
+ Hits          147      148       +1     
- Misses        500      527      +27     
- Partials       38       40       +2     
Impacted Files Coverage Δ
runc.go 21.01% <37.50%> (-0.07%) ⬇️
monitor.go 40.90% <0.00%> (-49.10%) ⬇️
io.go 6.45% <0.00%> (ø)
console.go 24.05% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ningmingxiao ningmingxiao force-pushed the dev1 branch 5 times, most recently from 1d04ce1 to 1590fae Compare January 18, 2022 12:45
Copy link
Member

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, added some non-functional suggestions for more idiomatic Go / reduces cyclomatic complexity, but overall LGTM.

Signed-off-by: ningmingxiao <[email protected]>
@ningmingxiao
Copy link
Contributor Author

done thankyou @austinvazquez

Copy link
Member

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! LGTM.

@kzys kzys merged commit 3e5515b into containerd:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants