-
Notifications
You must be signed in to change notification settings - Fork 80
fix opts maybe nill err #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 21.45% // Head: 20.69% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
- Coverage 21.45% 20.69% -0.77%
==========================================
Files 7 7
Lines 685 715 +30
==========================================
+ Hits 147 148 +1
- Misses 500 527 +27
- Partials 38 40 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
1d04ce1 to
1590fae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, added some non-functional suggestions for more idiomatic Go / reduces cyclomatic complexity, but overall LGTM.
Signed-off-by: ningmingxiao <[email protected]>
|
done thankyou @austinvazquez |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find! LGTM.
Signed-off-by: ningmingxiao [email protected]