Skip to content

Conversation

@Zyqsempai
Copy link
Contributor

Related #139

Signed-off-by: Boris Popovschi [email protected]

Signed-off-by: Boris Popovschi <[email protected]>
@Zyqsempai
Copy link
Contributor Author

@AkihiroSuda Let's merge this one for start and i will continue fixing the rest.

@AkihiroSuda
Copy link
Member

go mod tidy?

@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   33.98%   33.98%           
=======================================
  Files          35       35           
  Lines        2557     2557           
=======================================
  Hits          869      869           
  Misses       1551     1551           
  Partials      137      137
Impacted Files Coverage Δ
v2/utils.go 10.85% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 918ed86...7305d12. Read the comment docs.

Signed-off-by: Boris Popovschi <[email protected]>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AkihiroSuda AkihiroSuda merged commit 3f83850 into containerd:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants