This repository was archived by the owner on Dec 16, 2021. It is now read-only.
Create LibraryService and update AccountService #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
October 30, 2014 20:44
Contributor
Author
|
Green tests! Sorry for all the commits, my local PHPUnit is acting up, so I had to fire them off via this PR. |
added 6 commits
December 21, 2014 19:03
Conflicts: README.md
src/Ctct/Services/AccountService.php
Outdated
Contributor
There was a problem hiding this comment.
The array $emailAddresses is not converted to JSON before it is posted to the API. Currently there are no unit tests for this method, so the tests can pass while this does not work. In addition, this endpoint only accepts a single email address to be verified.
added 5 commits
January 14, 2015 09:24
egaiter
added a commit
that referenced
this pull request
Jan 14, 2015
Create LibraryService and update AccountService
Contributor
|
Changes have been tested and functioning. Unit tests pass as well. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.