This repository was archived by the owner on Dec 16, 2021. It is now read-only.
Bring development and master in sync #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the name of the apiKey var
Here's my dilemma: I want to use a different REST Client for the services, but because they are private, I would otherwise need to copy all the methods into my subclass in order to override the ConstantContact REST client. This way, I can do the following:
`
class KWSConstantContact extends ConstantContact {
public function __construct($apiKey) {
parent::__construct($apiKey);
$this->setRestClient(new CustomRestClient());
}
}
`
If there's a better way I don't know about, please let me know. Allowing sub-classes access seems like an easy way to add lots of flexibility without much risk.
Fixed howto
Allow sub-classes access to Services
Fixing phpdoc, ContactService, and PSR-2 code style compliance issues
Resolving broken contact service unit tests
Adding state parameter to OAuth flow
Upgrade to version 1.1.0
Changing case for PHPUnit tests
Resolving PSR1/2 Violations
Resolves issue w/ http_build_query on certain server configurations
Removing debug line
Adjusting campaign example
Resolving issue w/ campaign example and only selecting one list
Added deleteList functions
Cleaning Up Documentation
This adds a public, writeable $state field to the Address object for non-US/Canadian states/provinces/regions.
Add freeform "state" field (per API)
Updating Master
Added fields to contact_list array
Added created_date, modified_date to ContactList
…oks coming from constant contact.
Add WebHooksUtil Class
Implement better error handling mechanism. Now CtctExceotion is thrown even if the call to an endpoint is not successful.
Comments changed and better error handling.
Conflicts: docs/source-class-Ctct.Auth.CtctOAuth2.html docs/source-class-Ctct.Components.EmailMarketing.TestSend.html src/Ctct/Auth/CtctOAuth2.php src/Ctct/ConstantContact.php src/Ctct/Exceptions/OAuth2Exception.php src/Ctct/Services/ListService.php
Conflicts: src/Ctct/WebHooks/CTCTWebhookUtil.php
merging development to master
Revert error handling change
Remove duplicate use statement
Removed documentation( has been moved in the gh-pages branch ).
csciuto
added a commit
that referenced
this pull request
Oct 31, 2014
Bring development and master in sync
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.