Add EventSpot Components #131
Conversation
Still some things to do: - [ ] Build out EventSpotService.php to support [full range of methods](https://github.com/constantcontact/ruby-sdk/blob/master/lib/con stantcontact/services/event_spot_service.rb) - [ ] Some missing classes still exist
Also, fix the URL for promocode endpoints
…spot # Conflicts: # src/Ctct/Services/BaseService.php # src/Ctct/Util/Config.php
Update for PSR7
|
This looks pretty great so far. I'll take a more thorough look later on this week. |
Fix remaining methods to use `sendRequestWithBody()` instead of `send()`.
`OAuth2Exception::setErrors()` expects an array. `json_decode()` was sending an object.
|
@WoogieNoogie any chance to review? |
|
Thanks for the reminder, sorry for the wait, got caught up with some other things. I think this looks good, we'll get it merged into the development package. Do you need these to be accessible in a 1.x package? |
|
I did, but didn't think 1.x was in development still, so I've moved on to 2.x. |
|
Sorry, that was my fault, too many numbers flying around. I meant 2.x - the PR is opened to the dev branch which is currently on an alpha version of 3.x, which requires PHP 5.5, due to a Guzzle update in dependencies. I'll get this merged in, but I may need to take some time to merge this into the 2.x line, for the differences in the Guzzle calls. |
2 participants
I've attempted to add full EventSpot functionality.
I've implemented all the EventSpot API response objects as Components and have added inline documentation.
There are no tests written, but this is a solid start.