This repository was archived by the owner on Dec 16, 2021. It is now read-only.
Make GuzzleHttp\Client Injectable and Shared #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improved performance and decrease the memory usage by sharing a
single Client across all services.
* Allow a GuzzleHttp\Client to be injected during instantiation so
that a mock can be used for testing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GuzzleHttp\Clientacross all services.GuzzleHttp\Clientto be injected during instantiation so that a mock can be used for testing. The original intention was to allow third parties to use this for testing but it also enables improvements to the internal test suite.