Skip to content

DGS-21595 Allow alternate KMS key IDs on a KEK #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rayokota
Copy link
Member

@rayokota rayokota commented Aug 8, 2025

What

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

@Copilot Copilot AI review requested due to automatic review settings August 8, 2025 23:18
@rayokota rayokota requested review from a team as code owners August 8, 2025 23:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Implements support for alternate KMS key IDs on a KEK (Key Encryption Key) to provide fallback options for encryption/decryption operations.

  • Adds configuration parsing for alternate KMS key IDs from both rule config and KEK properties
  • Replaces direct AEAD calls with an AeadWrapper that tries multiple key IDs in sequence
  • Adds test coverage for the alternate KEK functionality

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 6 comments.

File Description
schemaregistry/serde/avrov2/avro_test.go Adds test case to verify encryption with alternate KMS key IDs configuration
schemaregistry/rules/encryption/encrypt_executor.go Implements AeadWrapper with fallback logic and alternate KMS key ID parsing

@sonarqube-confluent
Copy link

Failed

  • 0.00% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (55.10% Estimated after merge)
  • Duplications No duplication information (0.00% Estimated after merge)

Project ID: confluent-kafka-go

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant