antlr4-cppruntime: Upgrade to 4.12.0 #16328

0xFireWolf · 2023-02-28T10:01:54Z

Specify library name and version: antlr4-cppruntime/4.12.0

This PR contains the following changes:

Upgrade the runtime library to 4.12.0.
Upgrade the receipt to build the shared/static library only instead of both of them as of 4.12.0.
- Related Issue: C++ runtime will always build twice antlr/antlr4#3993
- Related PR: Cpp: cmake improvements antlr/antlr4#3996
- Related CMake Options: ANTLR_BUILD_SHARED and ANTLR_BUILD_STATIC
Drop the dependency utfcpp as of 4.10.0.
- Related PR: [C++] Implement standalone Unicode encoding and decoding handling antlr/antlr4#3398
Bump the dependency utfcpp to 3.2.3.

Thank you.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

ghost · 2023-02-28T10:16:39Z

I detected other pull requests that are modifying antlr4-cppruntime/all recipe:

antlr4-cppruntime: add version 4.12.0 #16159

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

michalwidera · 2023-03-04T22:13:04Z

Hi Eric, I'm gratefull that you take action here and bump 4.12.0 - But Antlr4 has one ugly methodology in their project development - they publish 1.x.0 version then in a few week later - 1.x.1 with bug fixes that is quite stable for some time. I'm Just checking https://github.com/antlr/antlr4/issues - I'm ok with bumping to 1.12.0 but this should be in the back of our heads. I've always wait for 1.x.1 stable version in mine project.

michalwidera

LGTM.

michalwidera · 2023-03-21T18:33:51Z

Look's like #16159 have solved conan-v2 issue.
Can we close this dup?

michalwidera

Please sync with #16159 and solve V2 build issue or close as DUP

0xFireWolf · 2023-03-21T18:53:49Z

Look's like #16159 have solved conan-v2 issue. Can we close this dup?

The V2 pipeline failed because prebuilt package for utfcpp is missing, so I don't think it has anything to do with my changes to the recipe. Besides, #16159 does not use the new CMake options ANTLR_BUILD_SHARED and ANTLR_BUILD_STATIC that can reduce the compile time by 50%.

======== Installing packages ========
ERROR: Missing binary: utfcpp/3.2.1:da39a3ee5e6b4b0d3255bfef95601890afd80709

utfcpp/3.2.1: WARN: Can't find a 'utfcpp/3.2.1' package binary 'da39a3ee5e6b4b0d3255bfef95601890afd80709' for the configuration:

ERROR: Missing prebuilt package for 'utfcpp/3.2.1'
Check the available packages using 'conan list utfcpp/3.2.1:* -r=remote'
or try to build locally from sources using the '--build=utfcpp/3.2.1' argument

0xFireWolf · 2023-03-21T18:58:59Z

Let me bump the dependency to utfcpp/3.2.3 to see if things still work.

0xFireWolf · 2023-03-22T00:10:31Z

@SpaceIm Could you please generate the package utfcpp/3.2.3 which is required by antlr4-cppruntime/4.9.3. The V2 pipeline failed because it cannot find prebuilt package on the server. I encountered the same error when I tested the recipe locally without passing the argument --build missing to Conan 2.0.2. Thank you in advance.

SpaceIm · 2023-03-22T00:49:13Z

I'm not a team member but a contributor like you, therefore I can't generate these binaries on-demand. You may want to ping @danimtb or @uilianries instead.

prince-chrismc · 2023-03-31T21:28:53Z

Binaries failed to get promoted #15016 (comment) 🤔

@jcar87 @uilianries @danimtb can you please take a peak ❤️

…th of them as of 4.12.0.

prince-chrismc · 2023-04-05T21:57:08Z

New version should not need new binaries for 🤞

prince-chrismc · 2023-04-07T22:01:22Z

😖 How can binaries exist if the dependency is missing

conan-center-index/.c3i/conan_v2_ready_references.yml

Line 11 in 5660ac5

- antlr4-cppruntime

0xFireWolf · 2023-04-07T22:11:11Z

😖 How can binaries exist if the dependency is missing

conan-center-index/.c3i/conan_v2_ready_references.yml

Line 11 in 5660ac5

- antlr4-cppruntime

Probably because the other PR #16159 got merged and the one who can update the Ready List decided to add antlr to the list. However, antlr's recipe does work with Conan 2.x, because I can build v4.9.3 with the argument --build missing. By the way, will the package for utfcpp be generated after your PR gets merged or just passes the V2 CI?

prince-chrismc · 2023-04-10T15:54:13Z

Yes! they should abe available now that it's merged so 🤞 everything goes through

prince-chrismc · 2023-04-10T18:44:18Z

V2 passed 🚀

conan-center-bot · 2023-04-10T19:01:44Z

Conan v1 pipeline ✔️

All green in build 13 (e21c294ebc3de83c716635ee0e09b878db67f148):

antlr4-cppruntime/4.12.0@:
All packages built successfully! (All logs)
antlr4-cppruntime/4.10.1@:
All packages built successfully! (All logs)
antlr4-cppruntime/4.9.3@:
All packages built successfully! (All logs)
antlr4-cppruntime/4.11.1@:
All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ✔️

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

All green in build 10 (e21c294ebc3de83c716635ee0e09b878db67f148):

antlr4-cppruntime/4.12.0@:
All packages built successfully! (All logs)
antlr4-cppruntime/4.11.1@:
All packages built successfully! (All logs)
antlr4-cppruntime/4.10.1@:
All packages built successfully! (All logs)
antlr4-cppruntime/4.9.3@:
All packages built successfully! (All logs)

prince-chrismc · 2023-04-10T21:40:30Z

Finally!!!!

* antlr4-cppruntime: Build the shared/static library only instead of both of them as of 4.12.0. * antlr4-cppruntime: Set the new CMake variables for 4.12.0 as well. * antlr4-cppruntime: Bump the dependency to `utfcpp/3.2.3`. * antlr4-cppruntime: Drop the dependency `utfcpp` as of 4.10.

conan-center-bot added the Service Under Maintenance label Feb 28, 2023

This comment has been minimized.

Sign in to view

ghost mentioned this pull request Feb 28, 2023

[service] Potentially conflicting recipes #3571

Closed

ghost mentioned this pull request Feb 28, 2023

antlr4-cppruntime: add version 4.12.0 #16159

Merged

3 tasks

github-actions bot mentioned this pull request Feb 28, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This was referenced Feb 28, 2023

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

0xFireWolf force-pushed the master branch from 7c49f6f to 79a41c4 Compare March 2, 2023 20:41

This comment has been minimized.

Sign in to view

conan-center-bot removed the Service Under Maintenance label Mar 9, 2023

This comment has been minimized.

Sign in to view

0xFireWolf force-pushed the master branch from 79a41c4 to 08e2845 Compare March 10, 2023 17:21

conan-center-bot added the Failed label Mar 10, 2023

This comment has been minimized.

Sign in to view

conan-center-bot removed the Failed label Mar 11, 2023

This comment has been minimized.

Sign in to view

michalwidera approved these changes Mar 21, 2023

View reviewed changes

ericLemanissier previously approved these changes Mar 21, 2023

View reviewed changes

michalwidera suggested changes Mar 21, 2023

View reviewed changes

0xFireWolf dismissed ericLemanissier’s stale review via 57a7f75 March 21, 2023 19:00

This comment has been minimized.

Sign in to view

prince-chrismc added the infrastructure Waiting on tools or services belonging to the infra label Mar 31, 2023

0xFireWolf dismissed stale reviews from prince-chrismc and michalwidera via 657f26b April 2, 2023 21:52

0xFireWolf closed this Apr 2, 2023

0xFireWolf force-pushed the master branch from 657f26b to 6b2f335 Compare April 2, 2023 21:55

0xFireWolf added 4 commits April 2, 2023 14:57

antlr4-cppruntime: Build the shared/static library only instead of bo…

eaee8ec

…th of them as of 4.12.0.

antlr4-cppruntime: Set the new CMake variables for 4.12.0 as well.

e829819

antlr4-cppruntime: Bump the dependency to utfcpp/3.2.3.

cb83363

antlr4-cppruntime: Drop the dependency utfcpp as of 4.10.

e21c294

0xFireWolf reopened this Apr 2, 2023

conan-center-bot removed the infrastructure Waiting on tools or services belonging to the infra label Apr 2, 2023

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Apr 5, 2023

utfcpp: add package_type and generate packages #16910

Merged

3 tasks

prince-chrismc approved these changes Apr 5, 2023

View reviewed changes

SSE4 approved these changes Apr 6, 2023

View reviewed changes

prince-chrismc closed this Apr 7, 2023

prince-chrismc reopened this Apr 7, 2023

This comment has been minimized.

Sign in to view

prince-chrismc closed this Apr 10, 2023

prince-chrismc reopened this Apr 10, 2023

conan-center-bot merged commit d49bea5 into conan-io:master Apr 10, 2023

antlr4-cppruntime: Upgrade to 4.12.0 #16328

antlr4-cppruntime: Upgrade to 4.12.0 #16328

Uh oh!

Conversation

0xFireWolf commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

ghost commented Feb 28, 2023

Uh oh!

This comment has been minimized.

michalwidera commented Mar 4, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

michalwidera left a comment

Choose a reason for hiding this comment

Uh oh!

michalwidera commented Mar 21, 2023

Uh oh!

michalwidera left a comment

Choose a reason for hiding this comment

Uh oh!

0xFireWolf commented Mar 21, 2023

Uh oh!

0xFireWolf commented Mar 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

0xFireWolf commented Mar 22, 2023

Uh oh!

SpaceIm commented Mar 22, 2023

Uh oh!

This comment has been minimized.

prince-chrismc commented Mar 31, 2023

Uh oh!

This comment has been minimized.

prince-chrismc commented Apr 5, 2023

Uh oh!

This comment has been minimized.

prince-chrismc commented Apr 7, 2023

Uh oh!

0xFireWolf commented Apr 7, 2023

Uh oh!

prince-chrismc commented Apr 10, 2023

Uh oh!

prince-chrismc commented Apr 10, 2023

Uh oh!

conan-center-bot commented Apr 10, 2023

Conan v1 pipeline ✔️

Conan v2 pipeline (informative, not required for merge) ✔️

Uh oh!

prince-chrismc commented Apr 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

0xFireWolf commented Feb 28, 2023 •

edited

Loading

0xFireWolf commented Mar 21, 2023 •

edited

Loading