WIP DON'T MERGE Add a test for missing string documentation #6501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amire80
force-pushed
the
test-qq
branch
3 times, most recently
from
0b4af5c to
38dd44b
Compare
THIS IS SUPPOSED TO FAIL AT THE MOMENT. Documentation for all the strings is already written in translatewiki (see commons-app#6457), but not yet imported into GitHub, so it's supposed to fail now, which is good because you shouldn't trust tests that never failed :) Once all the documentation strings are imported, this pull request should be rebased, and then it's supposed to pass. The extra string in values-qq/string.xml is also there just to check that it fails as it should, and will be removed. Resolves commons-app#6485.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
This patch adds a test for missing string documentation. Similar tests exist in Gerrit for MediaWiki and in the Wikipedia Android app, because complete documentation for every translatable string is very helpful to translators and developers.
THIS IS SUPPOSED TO FAIL AT THE MOMENT.
Documentation for all the strings is already written in translatewiki (see #6457), but not yet imported into GitHub, so it's supposed to fail now, which is good because you shouldn't trust tests that never failed :)
Once all the documentation strings are imported, this pull request should be rebased, and then it's supposed to pass.
The extra string in values-qq/string.xml is also there just to check that it fails as it should, and will be removed.
Resolves #6485.
Tests performed (required)
Tested locally using
./gradlew testBetaDebugUnitTest. This test (intentionally) failed, and gave a readable error description in the generated report.