Better error message when parsing hints in the upgrader #1830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1830 +/- ##
==========================================
+ Coverage 83.62% 83.69% +0.06%
==========================================
Files 44 44
Lines 8126 8124 -2
Branches 2223 2222 -1
==========================================
+ Hits 6795 6799 +4
+ Misses 851 848 -3
+ Partials 480 477 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mr-c
force-pushed
the
empty_hint_error
branch
2 times, most recently
from
6e38839 to
9882b53
Compare
Removed unnecessary checks for reqs/steps; the schema loader catches those
kinow
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @sjaenick for the report