Executor clears any saved result when execute is called. #1813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1813 +/- ##
=======================================
Coverage 83.62% 83.62%
=======================================
Files 44 44
Lines 8115 8117 +2
Branches 2219 2219
=======================================
+ Hits 6786 6788 +2
Misses 849 849
Partials 480 480
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mr-c
approved these changes
Mar 7, 2023
The executor interface is instanced rather than a constructor interface, and the most recent results are saved on the object as final_output and final_status. We should be able to invoke the executor more than once, however the current executor will not overwrite previously recorded results with new results. This change clears final_output and final_status each time execute() is called so that new results can be recorded.
mr-c
force-pushed
the
executor-reset-result
branch
from
c4af950 to
f48e4a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The executor interface is instanced rather than a constructor interface, and the most recent results are saved on the object as final_output and final_status. We should be able to invoke the executor more than once, however the current executor will not overwrite previously recorded results with new results. This change clears final_output and final_status each time execute() is called so that new results can be recorded.