Skip to content

Conversation

@BrunoGrandePhD
Copy link

I was working with the cwltool container image, and I was wondering if the intent with the cwltool-in-docker.sh entrypoint was to raise an error if both the Docker socket is unavailable and DOCKER_HOST is unset. I could be completely wrong, but I wanted to check just in case.

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #1809 (2eeacf6) into main (c69221b) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1809      +/-   ##
==========================================
+ Coverage   83.55%   83.59%   +0.03%     
==========================================
  Files          44       44              
  Lines        8102     8102              
  Branches     2218     2218              
==========================================
+ Hits         6770     6773       +3     
+ Misses        851      849       -2     
+ Partials      481      480       -1     
Impacted Files Coverage Δ
cwltool/workflow_job.py 87.42% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This was my error, introduced in 6b3e50b

@mr-c mr-c merged commit 12a9e77 into common-workflow-language:main Feb 16, 2023
@BrunoGrandePhD BrunoGrandePhD deleted the patch-1 branch February 16, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants