Skip to content

Conversation

@simleo
Copy link
Contributor

@simleo simleo commented Aug 30, 2022

When the workflow has no input or output files, the RO created by cwltool --provenance has no files under data/. In this case, no bagit manifest is created, making the RO bag invalid:

from bdbag.bdbagit import BDBag

bag = BDBag("ro")
bag.validate()
bagit.BagValidationError: No manifest files found

This PR changes ResearchObject so that it creates an empty manifest to fix the bagit structure in such cases.

@mr-c mr-c force-pushed the fix_prov_no_data branch from 485e9a5 to b388081 Compare August 30, 2022 15:55
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1727 (49b44e5) into main (49b44e5) will not change coverage.
The diff coverage is n/a.

❗ Current head 49b44e5 differs from pull request most recent head 54539b6. Consider uploading reports for the commit 54539b6 to get more accurate results

@@           Coverage Diff           @@
##             main    #1727   +/-   ##
=======================================
  Coverage   66.61%   66.61%           
=======================================
  Files          89       89           
  Lines       15846    15846           
  Branches     4188     4188           
=======================================
  Hits        10556    10556           
  Misses       4201     4201           
  Partials     1089     1089           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mr-c mr-c enabled auto-merge (rebase) August 30, 2022 15:58
@mr-c mr-c force-pushed the fix_prov_no_data branch from b388081 to 54539b6 Compare August 30, 2022 19:17
@mr-c mr-c merged commit 2a2216b into common-workflow-language:main Aug 30, 2022
@simleo simleo deleted the fix_prov_no_data branch August 31, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants