Skip to content

Conversation

@kinow
Copy link
Member

@kinow kinow commented Jul 14, 2022

logging.warn is deprecated since Py 3.3. Noticed the warnings (about logging.warn) in GH Actions logs for another PR.

To review, we can wait CI and just look at a pytest and/or mypy test to confirm there's no warning about warn.

-Bruno

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #1692 (1a61bc8) into main (88ab83d) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main    #1692   +/-   ##
=======================================
  Coverage   66.84%   66.84%           
=======================================
  Files          93       93           
  Lines       16670    16670           
  Branches     4422     4422           
=======================================
  Hits        11143    11143           
  Misses       4382     4382           
  Partials     1145     1145           
Impacted Files Coverage Δ
cwltool/job.py 80.27% <0.00%> (ø)
cwltool/main.py 71.98% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ab83d...1a61bc8. Read the comment docs.

@kinow kinow requested a review from mr-c July 14, 2022 11:04
@mr-c mr-c merged commit b126a46 into common-workflow-language:main Jul 14, 2022
@kinow kinow deleted the warn-deprecated branch July 14, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants