Skip to content

Conversation

@kinow
Copy link
Member

@kinow kinow commented Jun 1, 2022

Closes #1632

I think this should fix the issue reported, but not sure if there are other cases (file/directory) that would also require a similar fix.

@kinow kinow force-pushed the default-args-append branch from 22f12fb to 69e06f3 Compare June 1, 2022 01:02
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1675 (14ad829) into main (202b682) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1675      +/-   ##
==========================================
- Coverage   66.86%   66.83%   -0.04%     
==========================================
  Files          93       93              
  Lines       16622    16648      +26     
  Branches     4414     4420       +6     
==========================================
+ Hits        11114    11126      +12     
- Misses       4366     4380      +14     
  Partials     1142     1142              
Impacted Files Coverage Δ
cwltool/argparser.py 94.82% <100.00%> (+0.28%) ⬆️
cwltool/cwltool/argparser.py 72.11% <0.00%> (-2.68%) ⬇️
cwltool/cwltool/job.py 61.85% <0.00%> (-0.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 202b682...14ad829. Read the comment docs.

@kinow kinow force-pushed the default-args-append branch 6 times, most recently from 8770f5e to 07945a6 Compare June 1, 2022 02:20
@mr-c mr-c force-pushed the default-args-append branch from 07945a6 to 14ad829 Compare June 17, 2022 09:01
@mr-c mr-c enabled auto-merge (squash) June 17, 2022 09:02
@mr-c mr-c merged commit c23a9ed into common-workflow-language:main Jun 17, 2022
@kinow kinow deleted the default-args-append branch June 17, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default value in array stays

2 participants