Skip to content

Conversation

@RenskeW
Copy link
Contributor

@RenskeW RenskeW commented Apr 25, 2022

Node color/style:

  • CommandLineTool: "lightgoldenrodyellow", "filled"
  • Workflow: "#F3CEA1", "filled"
  • Operation: [no color], "dashed"

CommandLineTool & Workflow now have the same color as cwlviewer.

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1655 (bf8be2d) into main (d8b36d5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1655      +/-   ##
==========================================
- Coverage   66.82%   66.81%   -0.01%     
==========================================
  Files          93       93              
  Lines       16578    16586       +8     
  Branches     4404     4404              
==========================================
+ Hits        11078    11082       +4     
- Misses       4361     4365       +4     
  Partials     1139     1139              
Impacted Files Coverage Δ
cwltool/cwlviewer.py 98.90% <100.00%> (+0.05%) ⬆️
cwltool/cwltool/cwlviewer.py 21.97% <0.00%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8b36d5...bf8be2d. Read the comment docs.

@RenskeW RenskeW marked this pull request as ready for review April 25, 2022 05:36
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Can you add a test case that confirms the expected outcome? Perhaps using an workflow with each type of step represented?

Bonus if you paste in a picture of the resulting graph as a comment here 🙂

@RenskeW
Copy link
Contributor Author

RenskeW commented May 2, 2022

Schermafbeelding 2022-05-02 om 07 49 13

@RenskeW RenskeW requested a review from mr-c May 2, 2022 05:50
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah!

@mr-c mr-c merged commit 61c13dc into common-workflow-language:main May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants