Skip to content

Conversation

@mr-c
Copy link
Member

@mr-c mr-c commented Mar 3, 2022

No description provided.

@mr-c mr-c enabled auto-merge (rebase) March 3, 2022 20:01
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #1637 (75034e2) into main (12993a6) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1637      +/-   ##
==========================================
- Coverage   66.84%   66.82%   -0.03%     
==========================================
  Files          93       93              
  Lines       16578    16578              
  Branches     4404     4404              
==========================================
- Hits        11082    11078       -4     
- Misses       4357     4360       +3     
- Partials     1139     1140       +1     
Impacted Files Coverage Δ
cwltool/cwltool/docker.py 48.53% <0.00%> (-0.84%) ⬇️
cwltool/cwltool/job.py 61.85% <0.00%> (-0.80%) ⬇️
cwltool/job.py 80.27% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12993a6...75034e2. Read the comment docs.

@tetron
Copy link
Member

tetron commented Mar 7, 2022

Where does tmp_path come from, is it a pytest thing?

@mr-c
Copy link
Member Author

mr-c commented Mar 7, 2022

Where does tmp_path come from, is it a pytest thing?

Yep, it is a built-in pytest fixture

https://docs.pytest.org/en/6.2.x/tmpdir.html#the-tmp-path-fixture

https://docs.pytest.org/en/6.2.x/fixture.html

@mr-c mr-c merged commit 0f70992 into main Mar 7, 2022
@mr-c mr-c deleted the test_cleanups branch March 7, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants