Skip to content

Conversation

@dferber90
Copy link
Contributor

Specifies React version for eslint-plugin-react in .eslintrc.yaml to avoid a warning.

We use detect so that we don't need to upgrade the settings every time we upgrade React. The detect option was added to eslint-plugin-react in jsx-eslint/eslint-plugin-react#1978.

Before

image
see https://travis-ci.org/commercetools/ui-kit/builds/442629522?utm_source=github_status&utm_medium=notification

After

image

see https://travis-ci.org/commercetools/ui-kit/builds/442636937?utm_source=github_status&utm_medium=notification

Copy link
Contributor

@montezume montezume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@dferber90 dferber90 merged commit cd5b530 into master Oct 17, 2018
@dferber90 dferber90 deleted the df-add-eslint-react-version branch October 17, 2018 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants