Make ubuntu_setup.sh use codenames to support Ubuntu based distros #25261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using codenames allows the ubuntu_setup.sh to install properly on systems like Pop!_OS or Linux Mint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using codenames allows the ubuntu_setup.sh to install
properly on systems like Pop!_OS or Linux Mint.
Description
The change switches from ID and VERSION_ID to VERSION_CODENAME.
This makes the setup work on systems based on Ubuntu, as the codename still matches.
The relevant functions were also changed to reflect the codenames, as both 22.04 (jammy) and 20.04 (focal) are LTS.
Verification
Run the ubuntu_setup.sh on Pop!_OS 22.04