fingerprinting: bump CAN fingerprinting time and drain socket #24694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bump fingerprint time to 250ms
sshane
changed the title
Contributor
Author
|
Times to fingerprint the radar start message on a Hyundai Sonata: Seen first radar message at 290938.149397 ms
Started CAN fingerprinting at 290911.32897 ms
Difference of 26.82 ms (3 frames)
Seen first radar message at 307220.847198 ms
Started CAN fingerprinting at 307169.741698 ms
Difference of 51.11 ms (5 frames)
Seen first radar message at 281193.165079 ms
Started CAN fingerprinting at 281176.526134 ms
Difference of 16.64 ms (2 frames)
Seen first radar message at 264582.602829 ms
Started CAN fingerprinting at 264521.916087 ms
Difference of 60.69 ms (6 frames)
Seen first radar message at 59781.790494999994 ms
Started CAN fingerprinting at 59701.293152 ms
Difference of 80.5 ms (8 frames)
Seen first radar message at 349817.794001 ms
Started CAN fingerprinting at 349770.289496 ms
Difference of 47.5 ms (5 frames)
Seen first radar message at 225594.420219 ms
Started CAN fingerprinting at 225534.10707099998 ms
Difference of 60.31 ms (6 frames)
Seen first radar message at 78585.94970699999 ms
Started CAN fingerprinting at 78505.828249 ms
Difference of 80.12 ms (8 frames)
Seen first radar message at 164581.769901 ms
Started CAN fingerprinting at 164540.99499399998 ms
Difference of 40.77 ms (4 frames)
Seen first radar message at 247125.238177 ms
Started CAN fingerprinting at 247067.97928899998 ms
Difference of 57.26 ms (6 frames) |
maxime-desroches
pushed a commit
that referenced
this pull request
Jun 4, 2022
* add debugging script * debug * remove * add comment * timestamp CAN fingerprinting (to get time needed to wait for radar) * comment * need this to log * just in case, log first can packet logMonoTime * clean up * clean up * bump fingerprint time to 250ms bump fingerprint time to 250ms * comment
Contributor
|
FWIW - The frame_fingerprint value used to be 1s, until this PR... Reducing it to anything much lower apparently messes w/ some recognizing some people's C-SDSUs. |
Contributor
Author
|
Is it possible to have the SDSU send its fingerprint message much sooner? |
Contributor
The SDSUs I make don't have the problem, though I use official Panda hardware, and the 0x2ff is pretty early in code execution... It's the C-SDSU (Chinese clones) that have the problem, from what I've heard. Anyway, just making sure you were aware of |
spektor56
pushed a commit
to spektor56/ghostpilot
that referenced
this pull request
Jun 30, 2022
…i#24694) * add debugging script * debug * remove * add comment * timestamp CAN fingerprinting (to get time needed to wait for radar) * comment * need this to log * just in case, log first can packet logMonoTime * clean up * clean up * bump fingerprint time to 250ms bump fingerprint time to 250ms * comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.