Skip to content

process replay: fix branch name alert #23783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2022
Merged

process replay: fix branch name alert #23783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
302258d
env is modified after start
pd0wm Feb 17, 2022
0a85cc0
update ref
pd0wm Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions selfdrive/controls/lib/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
AudibleAlert = car.CarControl.HUDControl.AudibleAlert
EventName = car.CarEvent.EventName

REPLAY = "REPLAY" in os.environ

# Alert priorities
class Priority(IntEnum):
Expand Down Expand Up @@ -218,8 +217,9 @@ def func(CP: car.CarParams, sm: messaging.SubMaster, metric: bool, soft_disable_

def startup_master_alert(CP: car.CarParams, sm: messaging.SubMaster, metric: bool, soft_disable_time: int) -> Alert:
branch = get_short_branch("")
if REPLAY:
if "REPLAY" in os.environ:
branch = "replay"

return StartupAlert("WARNING: This branch is not tested", branch, alert_status=AlertStatus.userPrompt)

def below_engage_speed_alert(CP: car.CarParams, sm: messaging.SubMaster, metric: bool, soft_disable_time: int) -> Alert:
Expand Down
2 changes: 1 addition & 1 deletion selfdrive/test/process_replay/ref_commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ff965c772bd1bc85dec717d090cee4466033ce73
302258d8bdfea779c546f76c191ed451b18062f5