Skip to content

ui/get_path_length_idx: line_x[i] shoud be less than or equal to path_height #23336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2022
Merged

ui/get_path_length_idx: line_x[i] shoud be less than or equal to path_height #23336

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ecc740
start loop index from 1
deanlee Dec 30, 2021
fb24c66
use islessequal
deanlee Dec 30, 2021
e0dba98
use build in <=
deanlee Dec 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion selfdrive/ui/ui.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ static bool calib_frame_to_full_frame(const UIState *s, float in_x, float in_y,
static int get_path_length_idx(const cereal::ModelDataV2::XYZTData::Reader &line, const float path_height) {
const auto line_x = line.getX();
int max_idx = 0;
for (int i = 0; i < TRAJECTORY_SIZE && line_x[i] < path_height; ++i) {
for (int i = 1; i < TRAJECTORY_SIZE && std::islessequal(line_x[i], path_height); ++i) {
max_idx = i;
}
return max_idx;
Expand Down