ui: use YUV vipc stream

[deanlee]

No description provided.

[adeebshihadeh]

Is this ready for review? If not, what's missing?

[deanlee]

The only problem is c2 , do we need to use rgb on c2 and yuv on other devices?
c2 is optimized for rgb

[pd0wm]

What do you mean by C2 is optimized for RGB?

We want all devices to run the same code.

[deanlee]

how about EGLImageTexture? it's used for avoid rgb memory copy on C2, should we remove it?

[pd0wm]

You can remove it in this PR. We have to verify using the snapdragon profiler that the end result is the same or better.

You should still be able to skip the copy on C2 right?

[deanlee]

let's keep it until find a general way to avoid copy

[deanlee]

Now there is an additional VISIONSTREAM RGB MAP, Can it be changed to yuv format？

[pd0wm]

Not sure if it makes sense to convert that to YUV. Is it a problem to keep it as RGB for now? It's fine if displaying it in watch3 is inefficient, it only has to be viewed for debugging.

[deanlee]

it can't be displayed after this Pr.

[pd0wm]

That's ok. I'll think of a way to display it again after merging this. Feel free to remove it from watch3 temporarily.

[deanlee]

The cpu usage on c2 is almost the same as before after use YUV stream . I think it's ready for review now.

[jwooning]

I did some profiling on this PR and it seems there is no real performance or memory benefit yet.

Can you also look into the openCL kernels in camerad to use the yuv buffers, this should then allow to remove some of the used rgb buffers.

[pd0wm]

To save on memory bandwidth we need to skip the intermediate step into an RGB buffer, and make the debayer step go straight to a YUV output buffer. Feel free to only do the C2 debayer kernel first, so we can profile and see it there are any actual benefits.