[V3] hunyuan3d: make Voxel and Mesh types strict #9061
+33
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigcat88
requested review from
yoland68,
robinjhuang,
pythongosssss,
ltdrdata,
Kosinkadink,
webfiltered,
christian-byrne and
comfyanonymous
as code owners
|
For the migration process, we should not make any changes to the types being passed around. We'll be able to handle that sort of thing in the near future though, so definitely make a note of the idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR with suggestion to define the
VOXELandMESHtypes in the V3 schema as typed dictionaries.Anything typed is easier to check with linters and AI to get more correct context.
These V3 nodes do not work with V1, but since we plan to replace V1 with V3, nothing should break in existing workflows for community.
Tested changes: files produced by V1 and V3 nodes are identical.
If necessary, we can accept both the old
VOXEL/MESH, which is defined as a classes, and the new ones which is a typed dicts - so that compatibility would be perfect.