Skip to content

Replace manual x * sigmoid(x) with torch silu in VAE nonlinearity #9057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

Replace manual x * sigmoid(x) with torch silu in VAE nonlinearity #9057

merged 1 commit into from
Jul 30, 2025

Conversation

chaObserv
Copy link
Contributor

@chaObserv chaObserv commented Jul 26, 2025 •
edited
Loading

5b4e312 replaced nonlinearity with SiLU in ResnetBlock, but both Encoder and Decoder still have a call to nonlinearity. This PR also changes the nonlinearity in the old Cosmos vae.

Might be related to an old issue #1147.

@comfyanonymous comfyanonymous merged commit 61b08d4 into comfyanonymous:master Jul 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comfyanonymous comfyanonymous Awaiting requested review from comfyanonymous comfyanonymous is a code owner

Assignees
No one assigned
Labels
Core-Important
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaObserv @comfyanonymous @ltdrdata