Skip to content

Add xpu version for async offload and some other things. #9004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

simonlui
Copy link
Contributor

Besides adding async offload for XPU, I also did the following:

  • Cleaned up some xpu memory management and gated it by Pytorch version since it isn't clear what the minimum version of Pytorch ComfyUI actually enforces but I did see 2.3 used at the time of writing this so I went with that as kind of the minimum baseline for what needed a check and didn't.
  • Changed the checks for BF16 and FP16 on XPU to be more precise using device properties that exist now which can be queried and again, gated by Pytorch version.
  • Turned on non-blocking for XPU, this no longer freezes since around a year ago and speeds up stuff.

Again, works for my machine but ideally would get tested by others.

@simonlui simonlui requested a review from comfyanonymous as a code owner July 22, 2025 09:38
@comfyanonymous comfyanonymous merged commit 255f139 into comfyanonymous:master Jul 22, 2025
6 checks passed
@simonlui simonlui deleted the xpu-stream branch July 23, 2025 01:32
SurpassHR pushed a commit to SurpassHR/ComfyUI-Playground that referenced this pull request Jul 24, 2025
rakki194 pushed a commit to rakki194/ComfyUI that referenced this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants