Added parameter required_frontend_version in the /system_stats API response #8875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivansh-gupta4
requested review from
yoland68,
robinjhuang,
webfiltered,
pythongosssss,
ltdrdata and
Kosinkadink
as code owners
christian-byrne
requested changes
Jul 12, 2025
christian-byrne
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
LGTM
Tested by running app normally and checking system_stats response, confirming it sends the required frontend version from requirements.txt:
Then changed requirements.txt to have 1.24.1 frontend, but kept 1.23.4 installed. You can see the rqeuired_frontend_version field in system_stats reponse indicates what the versio should be, and the about panel shows what it actually is:
rakki194
pushed a commit
to rakki194/ComfyUI
that referenced
this pull request
Jul 29, 2025
…sponse (comfyanonymous#8875) * Added the parameter required_frontend_version in the /system_stats api response * Update server.py * Created a function get_required_frontend_version and wrote tests for it * Refactored the function to return currently installed frontend pacakage version * Moved required_frontend to a new function and imported that in server.py * Corrected test cases using mocking techniques * Corrected files to comply with ruff formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parameter required_frontend_version in the /system_stats API response
comfyui-frontend-packageparameter from the requirements.txt file to get the required frontend version for the backend and added that as an additional parameter in the response of /system_stats API.