Add support to rails 8.0 #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmorrison
approved these changes
Jul 30, 2024
chaadow
reviewed
Jul 30, 2024
| end | ||
|
|
||
| appraise "rails80" do | ||
| gem "rails", ">= 7.1.0.beta1", "< 8.1" |
There was a problem hiding this comment.
@danielmorrison @fernandomenolli
This is not rails 8. Rails 8 is the main branch which is 8.0.0.alpha which is NOT released on rubygems.
this will target at best 7.2.x
| - appraisal: rails71 | ||
| ruby: 2.6 | ||
| - appraisal: rails80 | ||
| ruby: 2.6 |
|
|
||
| gem.add_dependency "activerecord", ">= 5.2", "< 7.2" | ||
| gem.add_dependency "activesupport", ">= 5.2", "< 7.2" | ||
| gem.add_dependency "activerecord", ">= 5.2", "< 8.1" |
There was a problem hiding this comment.
@danielmorrison setting < 8.1 is the same as supporting rails main branch, which is "edge rails"
So why not just removing the upper bound like so gem.add_dependency "activerecord", ">= 5.2" so that PRs like this won't be necessary, and future PRs by contributors will be about fixing bugs on newer versions of rails, instead of these "Bump rails " kind of PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will: