Skip to content

Use new CSS class to prevent hidden text indicator #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2015
Merged

Use new CSS class to prevent hidden text indicator #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/assets/javascript/pageflow/embedded_video/page_type.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ pageflow.pageType.register('embedded_video', _.extend({
enhance: function(pageElement, configuration) {
var that = this;

pageElement.addClass('hide_content_with_text');
pageElement.addClass('no_hidden_text_indicator');

if (pageflow.features.has('mobile platform')) {
pageElement.find('.close_button, .iframe_container').click(function(event) {
Expand Down
13 changes: 0 additions & 13 deletions app/assets/stylesheets/pageflow/embedded_video.css.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,6 @@
@include pageflow-page-type(embedded_video);

.embedded_video_page {
/*
HACK: We need to set the hide_content_with_text css class on the
page's section, to make the menu button and hide text text
indicator disappear on mobile. But this also causes the content
to be hidden, which we undo in the following. This should be
decoupled in the pageflow gem.
*/
.content {
visibility: visible !important;
opacity: 1 !important;
pointer-events: all !important;
}

.contentText {
margin-top: 40px;
}
Expand Down
2 changes: 1 addition & 1 deletion pageflow-embedded-video.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ["lib"]

spec.add_runtime_dependency "pageflow", "~> 0.7"
spec.add_runtime_dependency "pageflow", "~> 0.10.pre"
spec.add_runtime_dependency 'i18n-js'

spec.add_development_dependency "bundler"
Expand Down