Skip to content

Conversation

Fourchaux
Copy link
Contributor

@Fourchaux Fourchaux commented May 7, 2019

Some typos from https://perl5.git.perl.org/perl.git/search/HEAD?s=typo;st=free

Note:

I would like to thank the Perl5 community for all these misspellings (800+ between 1989 and 2019!)
AS WELL AS their corrections...

@codecov-io
Copy link

codecov-io commented May 7, 2019

Codecov Report

Merging #1106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1106   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files           4        4           
  Lines         727      727           
  Branches      106      106           
=======================================
  Hits          664      664           
  Misses         46       46           
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de87a7...8fddc11. Read the comment docs.

obtaion->obtain
obtrain->obtain
obtrained->obtained
obverse->observe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a word

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Deleted.

paticularly->particularly
patrent->parent, patent, patron,
pattented->patented
patter->pattern
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a word, but maybe we should keep since there will presumably be way more true positives than false positives from including this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like a slippery slope to me; if you're going to do that, can they at least be pulled into a separate dictionary file instead and add the ability to use multiple dictionaries (if not already present). Then there's just the challenge of deciding what typos are sufficiently popular to be in the second file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should I do?
Delete the word?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.
'patter' & 'patters' deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants