Skip to content

Conversation

codesalatdev
Copy link
Owner

This PR adds the ability to extract the Level 3 category of an article by its id. This also re-enables the parameter add_category_name for the function get_article.

Fixes #15

@codesalatdev codesalatdev self-assigned this Oct 3, 2025
@codesalatdev codesalatdev added the enhancement New feature or request label Oct 3, 2025
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 81.03448% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.92%. Comparing base (66b02e6) to head (af44271).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/python_picnic_api2/helper.py 75.67% 9 Missing ⚠️
src/python_picnic_api2/client.py 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   71.36%   76.92%   +5.55%     
==========================================
  Files           4        4              
  Lines         227      260      +33     
==========================================
+ Hits          162      200      +38     
+ Misses         65       60       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codesalatdev codesalatdev marked this pull request as draft October 3, 2025 11:48
@codesalatdev
Copy link
Owner Author

client.get_article("s1072202", add_category=True)

output:

{'category': {'l2_id': 19401, 'l3_id': 19624, 'name': 'Kaffeegetränke'}, 'name': 'Arla Starbucks Starbucks Caffè Latte Eiskaffee', 'id': 's1072202'}

This is a breaking change.

@codesalatdev codesalatdev added the breaking Breaking changes label Oct 3, 2025
@codesalatdev codesalatdev marked this pull request as ready for review October 3, 2025 14:38
@codesalatdev codesalatdev merged commit 15d24b8 into main Oct 3, 2025
4 checks passed
@codesalatdev codesalatdev deleted the extract-category branch October 3, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking changes enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

category of an article

1 participant